From e2bccb4029e1a9c2e40b2f2b3363bc09312bd582 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20M=C3=B6rling?= Date: Thu, 21 May 2026 14:49:50 +0200 Subject: [PATCH] Include letter text in user-facing order API responses. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Users need the full message on Mina beställningar after creating an order. The admin API already exposed letterText; user list and payment confirm endpoints did not. - Add letterText field to OrderResponse DTO - Map letterText in OrderController.toResponse and PaymentController.toResponse - Assert letterText in OrderControllerTest list and create expectations --- .../main/java/se/bilhalsning/controller/OrderController.java | 1 + .../main/java/se/bilhalsning/controller/PaymentController.java | 1 + backend/src/main/java/se/bilhalsning/dto/OrderResponse.java | 1 + .../java/se/bilhalsning/controller/OrderControllerTest.java | 2 ++ 4 files changed, 5 insertions(+) diff --git a/backend/src/main/java/se/bilhalsning/controller/OrderController.java b/backend/src/main/java/se/bilhalsning/controller/OrderController.java index 818a57d..0c93aee 100644 --- a/backend/src/main/java/se/bilhalsning/controller/OrderController.java +++ b/backend/src/main/java/se/bilhalsning/controller/OrderController.java @@ -61,6 +61,7 @@ public class OrderController { return new OrderResponse( order.getId(), order.getPlate(), + order.getLetterText(), order.getStatus().getValue(), order.getTrackingId(), order.getAmountPaid(), diff --git a/backend/src/main/java/se/bilhalsning/controller/PaymentController.java b/backend/src/main/java/se/bilhalsning/controller/PaymentController.java index 36bd58f..63712e0 100644 --- a/backend/src/main/java/se/bilhalsning/controller/PaymentController.java +++ b/backend/src/main/java/se/bilhalsning/controller/PaymentController.java @@ -46,6 +46,7 @@ public class PaymentController { return new OrderResponse( order.getId(), order.getPlate(), + order.getLetterText(), order.getStatus().getValue(), order.getTrackingId(), order.getAmountPaid(), diff --git a/backend/src/main/java/se/bilhalsning/dto/OrderResponse.java b/backend/src/main/java/se/bilhalsning/dto/OrderResponse.java index 9620655..1c9a466 100644 --- a/backend/src/main/java/se/bilhalsning/dto/OrderResponse.java +++ b/backend/src/main/java/se/bilhalsning/dto/OrderResponse.java @@ -7,6 +7,7 @@ import java.util.UUID; public record OrderResponse( UUID id, String plate, + String letterText, String status, String trackingId, BigDecimal amountPaid, diff --git a/backend/src/test/java/se/bilhalsning/controller/OrderControllerTest.java b/backend/src/test/java/se/bilhalsning/controller/OrderControllerTest.java index 2f64887..3c4123d 100644 --- a/backend/src/test/java/se/bilhalsning/controller/OrderControllerTest.java +++ b/backend/src/test/java/se/bilhalsning/controller/OrderControllerTest.java @@ -83,6 +83,7 @@ class OrderControllerTest { .andExpect(status().isOk()) .andExpect(jsonPath("$[0].id").value("c1eebc99-9c0b-4ef8-bb6d-6bb9bd380a11")) .andExpect(jsonPath("$[0].plate").value("ABC123")) + .andExpect(jsonPath("$[0].letterText").value("Test letter")) .andExpect(jsonPath("$[0].status").value("sent")) .andExpect(jsonPath("$[0].trackingId").value("PN123456789")); } @@ -130,6 +131,7 @@ class OrderControllerTest { .andExpect(status().isCreated()) .andExpect(jsonPath("$.id").value("d1eebc99-9c0b-4ef8-bb6d-6bb9bd380a11")) .andExpect(jsonPath("$.plate").value("ABC123")) + .andExpect(jsonPath("$.letterText").value("Hej fin bil!")) .andExpect(jsonPath("$.status").value("pending_payment")); }