Compare commits

..

1 commit

Author SHA1 Message Date
Hermes Agent
b4fdcbff9e fix(guest): make Swish QR scannable on guest payment page
Some checks failed
CI / Lint, type check, unit tests, coverage (pull_request) Successful in 2m49s
CI / E2E browser tests (pull_request) Failing after 1m24s
The guest payment page (GuestPaymentRedirect.vue) still used the old
non-compliant QR settings that were already fixed in PaymentRedirect.vue
(commit 573153b). Desktop users scanning the QR with the Swish app could
not pay via QR on the guest checkout path.

Root cause: GuestPaymentRedirect.vue was not updated when the auth-path
QR fix was applied. It kept:
  - margin: 2 (half the ISO/IEC 18004 minimum of 4 modules)
  - color #111827 (dark gray; Swish spec requires pure black)
  - width: 224 (borderline for ~80-90 char pre-fill URLs)

Changes:
  - GuestPaymentRedirect.vue: QR options now match PaymentRedirect.vue
    exactly — margin 4, width 288, errorCorrectionLevel 'M',
    color #000000/#ffffff
  - CSS .payment__qr-img: 224px -> 288px to match the larger QR
  - GuestPaymentRedirect.spec.ts: renamed 'renders QR code after loading
    swish info' to 'renders QR code with spec-compliant settings' and
    added assertions verifying margin, width, and color options

Closes #22
2026-07-18 11:32:35 +00:00
9 changed files with 23 additions and 453 deletions

View file

@ -1,7 +1,7 @@
server { server {
listen 80; listen 80;
listen 443 ssl; listen 443 ssl;
server_name bilhej.se www.bilhej.se; server_name _;
ssl_certificate /etc/nginx/certs/cert.crt; ssl_certificate /etc/nginx/certs/cert.crt;
ssl_certificate_key /etc/nginx/certs/cert.key; ssl_certificate_key /etc/nginx/certs/cert.key;
@ -11,59 +11,20 @@ server {
root /usr/share/nginx/html; root /usr/share/nginx/html;
index index.html; index index.html;
# ── Security headers ──────────────────────────────────────────
add_header X-Frame-Options "DENY" always;
add_header X-Content-Type-Options "nosniff" always;
add_header X-XSS-Protection "1; mode=block" always;
add_header Referrer-Policy "strict-origin-when-cross-origin" always;
add_header Permissions-Policy "camera=(), microphone=(), geolocation=()" always;
# Strict-Transport-Security only when HTTPS is active
add_header Strict-Transport-Security "max-age=63072000; includeSubDomains; preload" always;
# ── Gzip ──────────────────────────────────────────────────────
gzip on;
gzip_types text/plain text/css application/json application/javascript text/xml
application/xml text/javascript image/svg+xml text/markdown;
gzip_vary on;
gzip_min_length 256;
gzip_comp_level 6;
# ── API reverse proxy ─────────────────────────────────────────
location /api/ { location /api/ {
proxy_pass http://backend:8080; proxy_pass http://backend:8080;
proxy_set_header Host $host; proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme; proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header X-Forwarded-Host $host;
} }
# ── Static assets with far-future cache ───────────────────────
location ~* \.(?:ico|svg|css|js|woff2?|ttf|eot|png|jpg|jpeg|gif|webp|avif)$ {
expires 1y;
add_header Cache-Control "public, immutable";
add_header Vary "Accept-Encoding";
try_files $uri =404;
}
# ── Robots + sitemap (never cached, fresh every time) ─────────
location = /robots.txt {
add_header Cache-Control "no-cache, must-revalidate";
try_files $uri =404;
}
location = /sitemap.xml {
add_header Cache-Control "no-cache, must-revalidate";
try_files $uri =404;
}
# ── SPA fallback serve index.html for all other routes ──────
location / { location / {
try_files $uri $uri/ /index.html; try_files $uri $uri/ /index.html;
} }
# ── Deny access to dotfiles ─────────────────────────────────── gzip on;
location ~ /\. { gzip_types text/plain text/css application/json application/javascript text/xml application/xml text/javascript image/svg+xml;
deny all; gzip_vary on;
return 404; gzip_min_length 256;
}
} }

View file

@ -4,143 +4,12 @@
<meta charset="UTF-8" /> <meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg?v=4" /> <link rel="icon" type="image/svg+xml" href="/favicon.svg?v=4" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> <meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="description" content="Skicka ett brev till en fordonsägare. Ange registreringsnummer, skriv ditt meddelande, så postar vi det." />
<!-- Primary Meta Tags -->
<title>Bilhej — Skicka brev till fordonsägare via registreringsnummer</title>
<meta name="title" content="Bilhej — Skicka brev till fordonsägare via registreringsnummer" />
<meta name="description" content="Skicka ett fysiskt brev till en fordonsägare. Ange registreringsnummer, skriv ditt meddelande, betala 49 kr via Swish. Vi postar brevet åt dig med spårning." />
<meta name="keywords" content="brev till bilägare, kontakta fordonsägare, registreringsnummer, skicka brev, anonymt meddelande, parkeringsskada, köp bilen, tuta, körbeteende, svensk post" />
<meta name="author" content="Bilhej" />
<meta name="robots" content="index, follow, max-image-preview:large" />
<meta name="language" content="Swedish" />
<meta name="theme-color" content="#1d4ed8" /> <meta name="theme-color" content="#1d4ed8" />
<link rel="canonical" href="https://bilhej.se/" />
<!-- Open Graph / Facebook -->
<meta property="og:type" content="website" />
<meta property="og:url" content="https://bilhej.se/" />
<meta property="og:title" content="Bilhej — Skicka brev till fordonsägare" />
<meta property="og:description" content="Skicka ett fysiskt brev till en bilägare via registreringsnummer. Skriv, betala 49 kr, vi postar." />
<meta property="og:site_name" content="Bilhej" />
<meta property="og:locale" content="sv_SE" />
<meta property="og:image" content="https://bilhej.se/og-image.png" />
<meta property="og:image:width" content="1200" />
<meta property="og:image:height" content="630" />
<!-- Twitter Card -->
<meta name="twitter:card" content="summary_large_image" />
<meta name="twitter:url" content="https://bilhej.se/" />
<meta name="twitter:title" content="Bilhej — Skicka brev till fordonsägare" />
<meta name="twitter:description" content="Skicka ett fysiskt brev till en bilägare via registreringsnummer. Skriv, betala 49 kr, vi postar." />
<meta name="twitter:image" content="https://bilhej.se/og-image.png" />
<!-- Performance: preconnect to font + analytics origins -->
<link rel="preconnect" href="https://fonts.googleapis.com" /> <link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link rel="preconnect" href="https://analytics.bilhej.se" />
<link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&display=swap" rel="stylesheet" /> <link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&display=swap" rel="stylesheet" />
<title>Bilhej — Skicka brev till fordonsägare</title>
<!-- Structured Data: Organization -->
<script type="application/ld+json">
{
"@context": "https://schema.org",
"@type": "Organization",
"name": "Bilhej",
"url": "https://bilhej.se",
"logo": "https://bilhej.se/favicon.svg",
"description": "Tjänst för att skicka fysiska brev till fordonsägare via registreringsnummer.",
"email": "kontakt@bilhej.se",
"contactPoint": {
"@type": "ContactPoint",
"email": "support@bilhej.se",
"contactType": "customer support",
"availableLanguage": ["Swedish"]
}
}
</script>
<!-- Structured Data: WebSite with SearchAction -->
<script type="application/ld+json">
{
"@context": "https://schema.org",
"@type": "WebSite",
"name": "Bilhej",
"url": "https://bilhej.se",
"inLanguage": "sv-SE",
"potentialAction": {
"@type": "ReadAction",
"target": "https://bilhej.se"
}
}
</script>
<!-- Structured Data: Service / Product -->
<script type="application/ld+json">
{
"@context": "https://schema.org",
"@type": "Service",
"name": "Bilhej — Brev till fordonsägare",
"description": "Skicka ett fysiskt brev till en fordonsägare genom att ange registreringsnummer. Swish-betalning, spårning och anonym avsändare.",
"url": "https://bilhej.se",
"provider": {
"@type": "Organization",
"name": "Bilhej",
"url": "https://bilhej.se"
},
"areaServed": {
"@type": "Country",
"name": "Sverige"
},
"offers": {
"@type": "Offer",
"price": "49",
"priceCurrency": "SEK",
"description": "Per brev: utskrift, kuvertering och postning"
}
}
</script>
<!-- FAQ Structured Data -->
<script type="application/ld+json">
{
"@context": "https://schema.org",
"@type": "FAQPage",
"mainEntity": [
{
"@type": "Question",
"name": "Hur skickar jag ett brev till en bilägare?",
"acceptedAnswer": {
"@type": "Answer",
"text": "Ange bilens registreringsnummer på bilhej.se, skriv ditt meddelande med en mall eller fritext, betala 49 kr via Swish, så postar vi brevet åt dig."
}
},
{
"@type": "Question",
"name": "Behöver jag veta vem som äger bilen?",
"acceptedAnswer": {
"@type": "Answer",
"text": "Nej, du behöver bara registreringsnumret. Vi kopplar brevet till rätt mottagare. Du ser aldrig mottagarens namn eller adress."
}
},
{
"@type": "Question",
"name": "Kan jag vara anonym?",
"acceptedAnswer": {
"@type": "Answer",
"text": "Ja, du kan nå bilägaren anonymt. Lägg bara till dina kontaktuppgifter i brevet om du vill att de ska kunna svara."
}
},
{
"@type": "Question",
"name": "Vad kostar det?",
"acceptedAnswer": {
"@type": "Answer",
"text": "49 kr per brev. Detta täcker utskrift, kuvertering och porto. Du betalar via Swish."
}
}
]
}
</script>
</head> </head>
<body> <body>
<div id="app"></div> <div id="app"></div>

View file

@ -1,27 +0,0 @@
# Allow all crawlers
User-agent: *
Crawl-delay: 10
Disallow: /api/
Disallow: /admin/
Disallow: /orders/
Disallow: /bestallning/*/redigera
Disallow: /betalning/*
Disallow: /gast-bestallning*
Disallow: /gast-betalning/*
Disallow: /gast-order/*
Disallow: /andra-losenord
Disallow: /andra-epost
Disallow: /bekrafta-epost
Disallow: /aterstall-losenord
Disallow: /glomt-losenord
# Allow important pages
Allow: /
Allow: /om-oss
Allow: /om
Allow: /kontakt
Allow: /integritetspolicy
Allow: /villkor
# Sitemap
Sitemap: https://bilhej.se/sitemap.xml

View file

@ -1,36 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9
http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd">
<url>
<loc>https://bilhej.se/</loc>
<changefreq>weekly</changefreq>
<priority>1.0</priority>
</url>
<url>
<loc>https://bilhej.se/om-oss</loc>
<changefreq>monthly</changefreq>
<priority>0.7</priority>
</url>
<url>
<loc>https://bilhej.se/om</loc>
<changefreq>monthly</changefreq>
<priority>0.3</priority>
</url>
<url>
<loc>https://bilhej.se/kontakt</loc>
<changefreq>monthly</changefreq>
<priority>0.6</priority>
</url>
<url>
<loc>https://bilhej.se/integritetspolicy</loc>
<changefreq>monthly</changefreq>
<priority>0.5</priority>
</url>
<url>
<loc>https://bilhej.se/villkor</loc>
<changefreq>monthly</changefreq>
<priority>0.5</priority>
</url>
</urlset>

View file

@ -1,29 +1,7 @@
<script setup lang="ts"> <script setup lang="ts">
import { watch } from 'vue'
import { useRoute } from 'vue-router'
import { RouterView } from 'vue-router' import { RouterView } from 'vue-router'
import AppHeader from '@/components/AppHeader.vue' import AppHeader from '@/components/AppHeader.vue'
import AppFooter from '@/components/AppFooter.vue' import AppFooter from '@/components/AppFooter.vue'
import { useSeo } from '@/composables/useSeo'
import { routeSeo } from '@/data/routeSeo'
const route = useRoute()
const seo = useSeo()
// Update title and meta tags on every route change
watch(
() => route.name,
(name) => {
const meta = routeSeo[name as string]
if (meta) {
seo.set(meta)
} else {
// Fallback for unnamed or dynamic routes (payment, guest, etc.)
seo.reset()
}
},
{ immediate: true },
)
</script> </script>
<template> <template>

View file

@ -124,12 +124,16 @@ describe('GuestPaymentRedirect', () => {
}) })
}) })
it('renders QR code after loading swish info', async () => { it('renders QR code with spec-compliant settings', async () => {
const { wrapper } = await mountPage() const { wrapper } = await mountPage()
await vi.waitFor(() => { await vi.waitFor(() => {
expect(wrapper.find('.payment__qr-img').exists()).toBe(true) expect(wrapper.find('.payment__qr-img').exists()).toBe(true)
}) })
expect(mockToDataURL).toHaveBeenCalledTimes(1) expect(mockToDataURL).toHaveBeenCalledTimes(1)
const options = mockToDataURL.mock.calls[0][1]
expect(options.margin).toBe(4)
expect(options.width).toBe(288)
expect(options.color).toEqual({ dark: '#000000', light: '#ffffff' })
}) })
it('renders Swish payment link', async () => { it('renders Swish payment link', async () => {

View file

@ -1,95 +0,0 @@
/**
* useSeo dynamically updates document <title> and meta tags on route change.
*
* Usage:
* const seo = useSeo()
* // On page mount / watch:
* watch(route, () => {
* seo.set({ title: 'Min sida', description: '...' })
* })
*
* The composable sets <title>, meta[name=description], meta[name=keywords],
* meta[property=og:title], meta[property=og:description], meta[name=twitter:title],
* and meta[name=twitter:description].
*/
export interface SeoMeta {
title: string
description: string
keywords?: string
ogTitle?: string
ogDescription?: string
canonical?: string
}
export function useSeo() {
function set(meta: SeoMeta) {
const title = meta.title ?? 'Bilhej'
const description =
meta.description ??
'Skicka brev till fordonsägare via registreringsnummer.'
// Document title
document.title = title
// Common meta tags
updateMeta('description', description)
if (meta.keywords) updateMeta('keywords', meta.keywords)
// Open Graph
updateMeta('og:title', meta.ogTitle ?? title, 'property')
updateMeta('og:description', meta.ogDescription ?? description, 'property')
// Twitter
updateMeta('twitter:title', meta.ogTitle ?? title, 'name')
updateMeta('twitter:description', meta.ogDescription ?? description, 'name')
// Canonical URL
updateCanonical(meta.canonical)
}
function reset() {
document.title = 'Bilhej — Skicka brev till fordonsägare'
updateMeta(
'description',
'Skicka ett fysiskt brev till en fordonsägare via registreringsnummer.',
)
updateMeta('og:title', 'Bilhej — Skicka brev till fordonsägare', 'property')
updateMeta(
'og:description',
'Skicka ett fysiskt brev till en fordonsägare via registreringsnummer.',
'property',
)
updateCanonical('https://bilhej.se/')
}
return { set, reset }
}
function updateMeta(
nameOrProperty: string,
content: string,
attr: 'name' | 'property' = 'name',
) {
let el = document.querySelector(
`meta[${attr}="${nameOrProperty}"]`,
) as HTMLMetaElement | null
if (!el) {
el = document.createElement('meta')
el.setAttribute(attr, nameOrProperty)
document.head.appendChild(el)
}
el.setAttribute('content', content)
}
function updateCanonical(href: string | undefined) {
let link = document.querySelector(
'link[rel="canonical"]',
) as HTMLLinkElement | null
if (!link) {
link = document.createElement('link')
link.setAttribute('rel', 'canonical')
document.head.appendChild(link)
}
link.setAttribute('href', href ?? 'https://bilhej.se/')
}

View file

@ -1,90 +0,0 @@
/**
* Route-level SEO metadata for Bilhej.
* Each entry maps route.name { title, description, keywords?, canonical? }
* These are applied by App.vue on every route change via useSeo().
*/
export interface RouteSeoMeta {
title: string
description: string
keywords?: string
/** The full canonical URL for this page */
canonical?: string
}
export const routeSeo: Record<string, RouteSeoMeta> = {
home: {
title: 'Bilhej — Skicka brev till fordonsägare via registreringsnummer',
description:
'Skicka ett fysiskt brev till en bilägare med bara registreringsnumret. Välj mall, skriv, betala 49 kr via Swish. Vi postar med spårning.',
keywords:
'brev till bilägare, kontakta fordonsägare, parkeringsskada, köp bil, skicka brev, registreringsnummer brev',
},
about: {
title: 'Om Bilhej — Skicka fysiska brev till fordonsägare online',
description:
'Bilhej gör det enkelt att nå en bilägare med ett fysiskt brev. Skriv meddelandet, vi sköter utskick och post. Anonymt eller med dina uppgifter.',
keywords: 'om bilhej, hur fungerar bilhej, skicka brev till bilägare',
},
contact: {
title: 'Kontakt — Bilhej support, klagomål och allmänna frågor',
description:
'Kontakta Bilhej via e-post. Support för beställningar och betalning, allmän kontakt och klagomål.',
keywords: 'bilhej kontakt, support bilhej, klagomål',
},
privacy: {
title: 'Integritetspolicy — Bilhej | Personuppgifter och GDPR',
description:
'Läs om hur Bilhej hanterar personuppgifter: vad vi samlar in, varför, hur länge och dina rättigheter enligt GDPR.',
keywords: 'integritetspolicy bilhej, gdpr, personuppgifter brev',
},
terms: {
title: 'Användarvillkor — Bilhej | Villkor för brevtjänsten',
description:
'Villkor för att använda Bilhej. Regler för brev till fordonsägare, betalning, ansvar och reklamation.',
keywords: 'användarvillkor bilhej, köpvillkor, brevtjänst villkor',
},
register: {
title: 'Registrera konto — Bilhej | Skapa konto för beställningar',
description:
'Skapa ett konto på Bilhej för att följa dina beställningar, se historik och hantera dina brev.',
},
login: {
title: 'Logga in — Bilhej | Dina brev till fordonsägare',
description:
'Logga in på Bilhej för att se dina beställningar, status och spårning.',
},
'forgot-password': {
title: 'Glömt lösenord — Bilhej | Återställ lösenord',
description:
'Återställ ditt lösenord på Bilhej. Få en återställningslänk via e-post.',
},
'guest-checkout': {
title: 'Gästbeställning — Bilhej | Skicka brev utan konto',
description:
'Skicka ett brev till en fordonsägare utan att skapa konto. Ange registreringsnummer, skriv meddelande, betala via Swish.',
keywords: 'gästbeställning bilhej, utan konto, snabb beställning',
},
compose: {
title: 'Skriv brev — Bilhej | Komponera meddelande till fordonsägare',
description:
'Skriv ditt brev till bilägaren. Välj mall för köp, komplimang, parkeringsskada eller tips, eller skriv fritt.',
},
orders: {
title: 'Mina beställningar — Bilhej | Följ dina brev',
description:
'Se dina tidigare och pågående beställningar. Följ status och spårning för brev du skickat.',
},
'change-password': {
title: 'Byt lösenord — Bilhej | Kontoinställningar',
description: 'Byt lösenord på ditt Bilhej-konto.',
},
'change-email': {
title: 'Byt e-postadress — Bilhej | Kontoinställningar',
description: 'Byt e-postadress på ditt Bilhej-konto.',
},
admin: {
title: 'Admin — Bilhej | Administrationspanel',
description:
'Administration av Bilhej — hantera beställningar och användare.',
},
}

View file

@ -52,9 +52,15 @@ onMounted(async () => {
if (swishPaymentUrl.value) { if (swishPaymentUrl.value) {
qrDataUrl.value = await QRCode.toDataURL(swishPaymentUrl.value, { qrDataUrl.value = await QRCode.toDataURL(swishPaymentUrl.value, {
width: 224, // Swish requires a reliably scannable black-on-white QR. The previous
margin: 2, // settings (margin 2, #111827, 224px) produced a 2-module quiet zone
color: { dark: '#111827', light: '#ffffff' }, // half the QR spec minimum which the Swish app's scanner fails to
// read when scanning off a screen. Use the spec-compliant 4-module
// quiet zone, pure black, and larger modules.
width: 288,
margin: 4,
errorCorrectionLevel: 'M',
color: { dark: '#000000', light: '#ffffff' },
}) })
} }
} catch { } catch {
@ -269,8 +275,8 @@ async function confirmPayment() {
} }
.payment__qr-img { .payment__qr-img {
width: 224px; width: 288px;
height: 224px; height: 288px;
border-radius: var(--radius-md); border-radius: var(--radius-md);
margin: 0 auto var(--space-sm); margin: 0 auto var(--space-sm);
} }