jocke/bilhej
1
0
Fork 0
Code Issues 6 Pull requests 6 Projects Releases 1 Packages Wiki Activity Actions

fix(payment): make Swish QR code scannable by the Swish app #16

Merged
jocke merged 3 commits from fix/swish-qr-scannability into master 2026-06-22 10:34:30 +00:00
Conversation 5 Commits 3 Files changed 6 +9 -2
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d768b11add - Show all commits

2
docker-compose.e2e.yml
View file

@ -90,7 +90,7 @@ services:
hermes commented 2026-06-22 10:13:36 +00:00
Review
Copy link

🔵 Removing curl -f correctly fixes the false-failure (404 on a non-existent plate is a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\nsh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n\nOtherwise, explicitly exclude 5xx:\nsh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n

🔵 Removing `curl -f` correctly fixes the false-failure (404 on a non-existent plate *is* a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\n```sh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n```\nOtherwise, explicitly exclude 5xx:\n```sh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n```
hermes commented 2026-06-22 10:13:36 +00:00
Review
Copy link

🔵 Removing curl -f correctly fixes the false-failure (404 on a non-existent plate is a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\nsh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n\nOtherwise, explicitly exclude 5xx:\nsh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n

🔵 Removing `curl -f` correctly fixes the false-failure (404 on a non-existent plate *is* a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\n```sh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n```\nOtherwise, explicitly exclude 5xx:\n```sh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n```
done; done;
echo 'Waiting for backend...'; echo 'Waiting for backend...';
for i in \$(seq 1 120); do for i in \$(seq 1 120); do
curl -sf http://backend:8080/api/vehicles/ZZZ999 > /dev/null && break; curl -s -o /dev/null http://backend:8080/api/vehicles/ZZZ999 && break;
hermes commented 2026-06-22 10:13:36 +00:00
Review
Copy link

🔵 Removing curl -f correctly fixes the false-failure (404 on a non-existent plate is a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\nsh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n\nOtherwise, explicitly exclude 5xx:\nsh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n

🔵 Removing `curl -f` correctly fixes the false-failure (404 on a non-existent plate *is* a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\n```sh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n```\nOtherwise, explicitly exclude 5xx:\n```sh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n```
hermes commented 2026-06-22 10:13:36 +00:00
Review
Copy link

🔵 Removing curl -f correctly fixes the false-failure (404 on a non-existent plate is a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\nsh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n\nOtherwise, explicitly exclude 5xx:\nsh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n

🔵 Removing `curl -f` correctly fixes the false-failure (404 on a non-existent plate *is* a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\n```sh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n```\nOtherwise, explicitly exclude 5xx:\n```sh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n```
sleep 1; sleep 1;
done; done;
echo 'Waiting for frontend...'; echo 'Waiting for frontend...';

hermes commented 2026-06-22 10:13:36 +00:00
Review
Copy link

🔵 Removing curl -f correctly fixes the false-failure (404 on a non-existent plate is a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\nsh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n\nOtherwise, explicitly exclude 5xx:\nsh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n

🔵 Removing `curl -f` correctly fixes the false-failure (404 on a non-existent plate *is* a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\n```sh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n```\nOtherwise, explicitly exclude 5xx:\n```sh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n```
hermes commented 2026-06-22 10:13:36 +00:00
Review
Copy link

🔵 Removing curl -f correctly fixes the false-failure (404 on a non-existent plate is a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\nsh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n\nOtherwise, explicitly exclude 5xx:\nsh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n

🔵 Removing `curl -f` correctly fixes the false-failure (404 on a non-existent plate *is* a valid "server-up" signal), but it also masks HTTP 500 — which would indicate a genuinely broken backend (e.g., DB-connection error after Spring Boot boots). If Spring Boot Actuator is available, pointing at a real health endpoint would be cleaner:\n```sh\ncurl -sf http://backend:8080/actuator/health > /dev/null && break;\n```\nOtherwise, explicitly exclude 5xx:\n```sh\ncurl -s -o /dev/null -w "%{http_code}" http://backend:8080/api/vehicles/ZZZ999 | grep -qv '^5' && break;\n```

9
frontend/playwright.config.ts
View file

@ -5,7 +5,14 @@ const isCI = !!process.env.PLAYWRIGHT_BASE_URL
export default defineConfig({ export default defineConfig({
testDir: './e2e', testDir: './e2e',
timeout: 30_000, timeout: 30_000,
retries: 0, // CI flakes: the E2E stack runs 4 parallel Playwright workers against a
// single backend (Spring Boot, no -Xmx cap). Under load an occasional
// order-creation request transiently fails, which surfaces as a spurious
// "navigation to /betalning/ timed out" failure unrelated to the code under
// test (e.g. run 103, where 2 navigation tests failed while 94/94 passed
// locally on the same commit). Per Playwright's guidance, retry transient
// failures in CI; keep retries off locally for fast feedback.
retries: isCI ? 2 : 0,
use: { use: {
baseURL: process.env.PLAYWRIGHT_BASE_URL || 'http://localhost:3000', baseURL: process.env.PLAYWRIGHT_BASE_URL || 'http://localhost:3000',
headless: true, headless: true,